Allow SScope to have unused keyword arguments #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of issue #42 |
jmichelp
reviewed
Jan 17, 2022
The SScope is expected to be initialized using capture_info (to have all information present in capture_info). But capture_info might contain more information which is not needed to initialize SScope. This commit allows SScope to ignore the rest of the capture_info.
kralka
force-pushed
the
scope_ignore_other_kwargs
branch
from
d5de8a5
to
3ef5a78
Compare
jmichelp
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SScope is expected to be initialized using capture_info (to have all
information present in capture_info). But capture_info might contain
more information which is not needed to initialize SScope. This commit
allows SScope to ignore the rest of the capture_info.