Export stats struct/publisher interface for monitoring #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyuan10
reviewed
Jun 28, 2020
liuyuan10
reviewed
Jul 10, 2020
hazaelsan
reviewed
Jul 10, 2020
|
could you squash all your commit into one? I don't see they need to be separate. |
|
@DrJosh9000 In case you missed it, please squash the commits into a single one in this RP as I said above. Thanks |
Currently, exporting monitoring metrics would require patching the ecu package to add the necessary functionality. Exporting the types allows an implementation to provide a statistics publisher via the ECU config. This PR also makes a few changes to how ecu/stats.go operates.
|
Never mind, I needed to |
hazaelsan
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, exporting monitoring metrics would require patching the ecu
package to add the necessary functionality. Exporting the types allows
an implementation to provide a statistics publisher via the ECU config.
This PR also makes a few changes to how ecu/stats.go operates.