Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iframe #86

Closed
icy0307 opened this issue Mar 22, 2022 · 2 comments
Closed

Support iframe #86

icy0307 opened this issue Mar 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@icy0307
Copy link

icy0307 commented Mar 22, 2022 •
edited

Describe the feature
Please support semantic-locators works in iframe.
accname used to use node instanceof HTMLElement, that will not work on elements that belong to other windows/frames.
It seems that this problem got fixed, but never publish to npm?
google/accname@466d7e9

Use case
I'm trying to add a custom command to cypress, and cypress runs everything inside an iframe

Awesome library. Thx. @AlexLloyd0
@icy0307 icy0307 added the enhancement New feature or request label Mar 22, 2022
@AlexLloyd0
Copy link
Contributor

Thanks for reporting this! I'm working on publishing a new accname release now, I'll update and release semantic locators next week :)

@AlexLloyd0
Copy link
Contributor

2.1.0 is deployed to npm, Maven and pypi, which includes the latest version of Accname!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icy0307 @AlexLloyd0