Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VERSION file #583

Closed
ryandesign opened this issue Nov 11, 2020 · 1 comment
Closed

Rename VERSION file #583

ryandesign opened this issue Nov 11, 2020 · 1 comment

Comments

@ryandesign
Copy link
Contributor

Hi, I'm a developer with MacPorts, where we have a port for sentencepiece and noticed this compilation failure:

version:1:1: error: expected unqualified-id
0.1.84
^

This happens in the following situation: the compiler is new enough to support the C++17 <version> header, and the filesystem is case insensitive (which it normally is on macOS).

Could you perhaps rename the VERSION file to avoid this problem? If you have any references to the file elsewhere in your sources those would need to be updated too.

@taku910
Copy link
Collaborator

taku910 commented Nov 12, 2020

Changed the name in the master branch. If we don't see any problems, this fix is included in the next release. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants