Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users (of Waterfox) to be aware of a registration before the Service Worker becomes active #11

Closed
grahamperrin opened this issue May 25, 2018 · 2 comments

Comments

@grahamperrin
Copy link

grahamperrin commented May 25, 2018

Enhancement request

Please, would you consider adding a user preference that allows an icon of Service Worker Detector to be seen whilst a worker is inactive?

I reckon, there need not be a GUI to the preference. A boolean in about:config might suffice.

I can encourage someone in or around the Waterfox project to make a pull request. (I'd do so myself, but I don't have coding skills.)

Background

Firefox Quantum benefits from its page actions menu, where Service Worker Detector can present itself whilst a worker is inactive.

Waterfox 56.2.0 does not have that benefit.

Perspectives

https://www.reddit.com/comments/8hz93r/-/dyoabtb/ draws attention to the progressive, pro-Photon viewpoint of Waterfox project leader Alex Kontos – I assume that there'll be the page actions menu, and other things that are associated with Photon, in due course.

Somewhere between acceptance of service workers (my viewpoint) and blanket refusal (dom.serviceWorkers.enabled false and so on), there's a subset of users where interest in service workers overlaps with caution and sometimes, scepticism. Some people in this subset will appreciate a visual hint, from Service Worker Detector, that there's a registration.

@tomayac
Copy link
Member

tomayac commented May 25, 2018

I think this is out of scope for the extension in its current form, as it's supposed to report on active Service Workers only.

You (or for what it's worth, the Waterfox folks) are free, however, to fork the extension and instead of reacting on navigator.serviceWorker.controller, that is, active Service Workers (deeplink to where this happens), listen instead for:

  • ServiceWorkerRegistration.installing (docs)
  • ServiceWorkerRegistration.waiting (docs)
  • ServiceWorkerRegistration/onupdatefound (docs)

@tomayac tomayac closed this as completed May 25, 2018
@grahamperrin
Copy link
Author

@tomayac thanks!

@MrAlex94 FYI:

I guess that sooner or later, a question there will lead to the information here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants