New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching to using git submodules instead of manually checking out repos #10
Comments
In the short term, fixing the current problem with |
Thanks for the suggestion! It's done in #13. shaderc requires a certain directory hierarchy for its dependencies. Right now shaderc itself does not manage its dependencies as Git submodules. To use Git submodule here, we need to register nested submodules (in shaderc-rs), which I don't think Git supports right now. So I created an umbrella |
This would make managing the dependencies on other repositories much more straightforward and less error prone. For example, at the moment a clean build will work, but if you try to build again after that it will fail, since the
git pull
commands fail due to the checked out repos not being on a branch (instead they are pinned to a commit). With git submodules you can remove all of the git related code from the build script.The text was updated successfully, but these errors were encountered: