Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Assets are disabled in asset list #1214

Closed
TheModMaker opened this issue Jan 4, 2018 · 1 comment
Closed

TS Assets are disabled in asset list #1214

TheModMaker opened this issue Jan 4, 2018 · 1 comment
Assignees
@michellezhuogg
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.4

Comments

@TheModMaker
Copy link
Contributor

The TS assets from Bitcodin are disabled in the demo app. This is caused by the support probe not detecting either the transmuxing or the presence of muxjs. The support page doesn't show TS support even though we support it through transmuxing. The assets are playable if I manually enter the URL or I remove the support check code.

On a related note, I see a bunch of 403 errors on preflight checks when I play the assets. This doesn't stop playback though, since this is only for the start time calculations (I think).
@TheModMaker TheModMaker added type: bug Something isn't working correctly flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue labels Jan 4, 2018
@TheModMaker TheModMaker added this to the v2.4.0 milestone Jan 4, 2018
@osmestad osmestad mentioned this issue Jan 18, 2018
Closed
@michellezhuogg michellezhuogg self-assigned this Feb 22, 2018
@joeyparrish joeyparrish mentioned this issue Mar 21, 2018
Closed
joeyparrish pushed a commit that referenced this issue Mar 21, 2018
@michellezhuogg @joeyparrish
Enable TS Assets in demo asset list
d987557 
The Transport Stream assets (Art of Motion(HLS,TS) and Sintel(HLS,TS,4k))
were disabled in the demo app, because the assets were only filtered by
native platform support.

Backported to v2.3.x

Closes #1214.

Change-Id: I03b60df291813b4669889fc8f8500627d206b28a
@joeyparrish
Copy link
Member

Fix cherry-picked for v2.3.4.

@shaka-project shaka-project locked and limited conversation to collaborators Apr 24, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellezhuogg michellezhuogg

Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @shaka-bot @michellezhuogg