Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to ui.configure should not create a new controls object #1948

Closed
ismena opened this issue May 16, 2019 · 2 comments
Closed

Call to ui.configure should not create a new controls object #1948

ismena opened this issue May 16, 2019 · 2 comments
Assignees
@ismena
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@ismena
Copy link
Contributor

ismena commented May 16, 2019

Might be related to #1941

Every time ui.configure is called,we recreate the shaka.ui.Controls object.
This means, the apps can no longer rely on the object they got from ui.getControls() prior to the config call and the castProxy object also is different.

Controls and castProxy need a way to change without being re-created.
@ismena ismena self-assigned this May 16, 2019
@ismena ismena added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI labels May 16, 2019
@shaka-bot shaka-bot added this to the v2.6 milestone May 16, 2019
shaka-bot pushed a commit that referenced this issue May 16, 2019
@theodab
Made demo properly re-connect to cast sessions.
7aae7ed 
Note that this does not fully fix the problem; issue #1948 means
that if the ui is configured more than once, we cannot cast at all.
Also, the cast receiver does not currently work; once a v2.5.1 version
is released that will no longer be an issue, but the v2.5.0 version
currently uploaded is missing goog.require calls.
I have manually verified that once those issues are fixed, though,
this will allow for the player to re-connect.

Issue #1948

Change-Id: I26201cc696a61906fac3c320f9ac5e4b61fe1920
joeyparrish pushed a commit that referenced this issue May 20, 2019
@theodab @joeyparrish
Made demo properly re-connect to cast sessions.
b886024 
Note that this does not fully fix the problem; issue #1948 means
that if the ui is configured more than once, we cannot cast at all.
Also, the cast receiver does not currently work; once a v2.5.1 version
is released that will no longer be an issue, but the v2.5.0 version
currently uploaded is missing goog.require calls.
I have manually verified that once those issues are fixed, though,
this will allow for the player to re-connect.

Issue #1948

Change-Id: I26201cc696a61906fac3c320f9ac5e4b61fe1920
@theodab theodab mentioned this issue May 28, 2019
Closed
shaka-bot pushed a commit that referenced this issue May 30, 2019
@ismena
Don't recreate controls object on configure() calls.
5723324 
Issue #1948

Change-Id: I86a10c61d704688b2830e7f08b894a98faaf68e7
joeyparrish pushed a commit that referenced this issue Jun 1, 2019
@ismena @joeyparrish
Don't recreate controls object on configure() calls.
9bec712 
Issue #1948

Backported to v2.5.x

Change-Id: I86a10c61d704688b2830e7f08b894a98faaf68e7
shaka-bot pushed a commit that referenced this issue Jun 3, 2019
@ismena
Add a temporary fix to enable casting.
3e3e940 
Issue #1948

Change-Id: Id3953cdc32f1cdd02729c1a3f08c522b2ee376f1
@joeyparrish
Copy link
Member

@ismena, should we close this bug now? Or is there more to do?

@ismena
Copy link
Contributor Author

ismena commented Jun 4, 2019

I think, we can close this one and open another to track the progress on our casting saga.

@ismena ismena closed this as completed Jun 5, 2019
@theodab theodab mentioned this issue Jun 14, 2019
Closed
TheModMaker pushed a commit that referenced this issue Jul 11, 2019
@ismena @TheModMaker
Add a temporary fix to enable casting.
8c37740 
Issue #1948

Change-Id: Id3953cdc32f1cdd02729c1a3f08c522b2ee376f1
AnteWall pushed a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
@ismena @AnteWall
Don't recreate controls object on configure() calls.
9f36862 
Issue shaka-project#1948

Change-Id: I86a10c61d704688b2830e7f08b894a98faaf68e7
AnteWall pushed a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
@ismena @AnteWall
Add a temporary fix to enable casting.
316ad3d 
Issue shaka-project#1948

Change-Id: Id3953cdc32f1cdd02729c1a3f08c522b2ee376f1
@shaka-project shaka-project locked and limited conversation to collaborators Aug 4, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@ismena @joeyparrish @shaka-bot