Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ending support for IE 11 after v3.0 #2339

Closed
joeyparrish opened this issue Jan 13, 2020 · 6 comments
Closed

Ending support for IE 11 after v3.0 #2339

joeyparrish opened this issue Jan 13, 2020 · 6 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: announcement An announcement from the team; generally pinned to the top
Milestone

Comments

@joeyparrish
Copy link
Member

joeyparrish commented Jan 13, 2020

TL;DR: Shaka Player will no longer support IE11 beyond v3.0.x

Shaka Player has supported IE 11 since v1.6.0, added in PR #176 and released a little more than 4 years ago. At that time, IE 11 usage was significantly higher than Edge, and it was still a very important target for many providers.

Since that time, IE 11 usage has steadily declined. We use browser usage data from caniuse.com to help drive our support decisions, and those data indicate that IE usage has now fallen below Edge usage for the first time since we've been watching.

Even Microsoft maintains that IE 11 is only a "compatibility solution" for outdated web apps. We don't think Shaka Player fits that description. With the introduction of a Chromium-based Edge on January 15, 2020 with builds for Windows 7 & 8, there is now even less reason to continue supporting IE 11.

IE 11 support has only gotten more expensive for us. There are over 91 references to IE workarounds and restrictions in our codebase. We have three custom polyfills totalling 800+ lines just for IE. IE has gotten even more problematic for us since the introduction of the Shaka Player UI in v2.5, since one of IE's weakest points is its outdated CSS implementation.

For these reasons, the upcoming v3.0 release of Shaka Player will be the last release branch with IE11 support. When we stop making maintenance releases for v3.0, we will remove IE from our test lab and our list of supported platforms.

Please feel free to leave your feedback, positive or negative, on this GitHub issue. Thanks for reading!

-Joey, on behalf of the Shaka Player Team

@joeyparrish joeyparrish added the type: announcement An announcement from the team; generally pinned to the top label Jan 13, 2020
@joeyparrish joeyparrish pinned this issue Jan 13, 2020
@joeyparrish joeyparrish added the flag: bot ignore Asks CI bots that maintain issues to ignore this issue label Jan 13, 2020
@alexandercerutti
Copy link
Contributor

alexandercerutti commented Jan 15, 2020

I think it could be useful to add a link to this announcement on the main README.md on note number 4 (IE) of the compatibility table or add a new note. What do you think about it?

@joeyparrish
Copy link
Member Author

Good idea! I'll do that.

shaka-bot pushed a commit that referenced this issue Jan 24, 2020
Issue #2339

Change-Id: I1a345e49e80a90aeaf1b9471a587c73a5646befa
joeyparrish added a commit that referenced this issue Feb 4, 2020
Issue #2339

Change-Id: I1a345e49e80a90aeaf1b9471a587c73a5646befa
shaka-bot pushed a commit that referenced this issue Feb 11, 2020
Since IE 11 only supports this field partially and only with deprecated
css values, do not test it for now. We'll add it back once we end
support for IE 11.

Issue #2339
https://buganizer.corp.google.com/issues/146050219

Change-Id: I9458ea830027a312e5237c406de3ed2ecba62918
@joeyparrish joeyparrish changed the title Ending support for IE 11 after v2.6.x Ending support for IE 11 after v3.0 May 28, 2020
@joeyparrish
Copy link
Member Author

Please note that although the plan & timeline for IE deprecation has not changed, we have decided to rename v2.6 to v3.0.

@avelad
Copy link
Collaborator

avelad commented Mar 1, 2021

@joeyparrish In which version is this issue going to be solved, in 3.1 or in 4.0? After seeing the post of version 4.0 and the follow-up of a semantic version, I would like to clarify this.

@joeyparrish
Copy link
Member Author

Excellent question. We had decided to drop support for IE before the switch to v3.0, and with the transition to v3.0, also announced that we would end IE support in v3.1. Apologies if this is confusing (or cheating) in terms of semantic versioning.

@joeyparrish joeyparrish added this to the v3.1 milestone Mar 1, 2021
joeyparrish pushed a commit that referenced this issue Apr 16, 2021
@ismena
Copy link
Contributor

ismena commented Apr 23, 2021

Closed by #3309

@ismena ismena closed this as completed Apr 23, 2021
shaka-bot pushed a commit that referenced this issue Apr 29, 2021
Issue #2339

Change-Id: I80ffa7b04f7afd943aa0f881d2a494dd35def732
@joeyparrish joeyparrish removed the flag: bot ignore Asks CI bots that maintain issues to ignore this issue label Apr 29, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 23, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: announcement An announcement from the team; generally pinned to the top
Projects
None yet
Development

No branches or pull requests

6 participants