Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis as CI #364

Closed
leandromoreira opened this issue May 3, 2016 · 1 comment
Closed

Add Travis as CI #364

leandromoreira opened this issue May 3, 2016 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated status: working as intended The behavior is intended; this is not a bug

Comments

@leandromoreira
Copy link
Contributor

Mostly to run the tests, it helps by providing each PR with a build pass or not.

If that's fine, I'm willing to do so.

@joeyparrish
Copy link
Member

We run our tests with karma, and we already have a Jenkins-based build bot that builds and tests each PR on real browsers and real hardware. We test PRs on Chrome Linux and we run all tests nightly on Linux, Mac, and Windows using Chrome, Firefox, Opera, IE 11, Edge, and Safari.

Our build bot is already integrated with github and reports status back to the pull request. For an example of what this looks like, see: #315 (comment)

Our integration tests require HTML5 video, MSE, and EME. Running tests on PhantomJS won't work because they don't have HTML5 video (issue). We stopped using BrowserStack because of their lack of PlayReady support, among other reasons. We also considered SauceLabs, but they don't support PlayReady and don't seem to be considering it at the moment (ticket).

So far, the only solid solution we have found is to run our tests on real hardware, so I don't think Travis is viable at the moment. Since we already have a bot that tests PRs, I'm going to close this as "working as intended". Thanks!

@joeyparrish joeyparrish added the status: working as intended The behavior is intended; this is not a bug label May 3, 2016
@joeyparrish joeyparrish self-assigned this May 3, 2016
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: working as intended The behavior is intended; this is not a bug
Projects
None yet
Development

No branches or pull requests

3 participants