Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

All versions of third-party tools should be manually pinned #84

Open
ciera opened this issue Sep 28, 2015 · 5 comments
Open

All versions of third-party tools should be manually pinned #84

ciera opened this issue Sep 28, 2015 · 5 comments
Labels
P1

Comments

@ciera
Copy link
Contributor

ciera commented Sep 28, 2015

Right now, the docker file always gets the latest version of all tools. We may want to manually pin some of these to ensure that we don't break a stable release. This is especially true of the analyzers.
@ciera ciera added the P2 label Sep 28, 2015
@ciera ciera added P1 and removed P2 labels Oct 7, 2015
@tedks
Copy link
Contributor

tedks commented Oct 8, 2015

Fixed in 2e226f9.

@tedks tedks closed this as completed Oct 8, 2015
@ciera ciera reopened this Oct 13, 2015
@ciera
Copy link
Contributor Author

ciera commented Oct 13, 2015

Reopening, the jshint change was broken.

@ciera ciera closed this as completed Oct 13, 2015
@ciera ciera reopened this Oct 13, 2015
@supertriceratops
Copy link
Contributor

Did you have to rollback the entire jshint change? Did you try keeping the part that pinned the version?

@ciera
Copy link
Contributor Author

ciera commented Oct 15, 2015

I rolled back the entire change; was not sure which parts would work without the others.

@tedks
Copy link
Contributor

tedks commented Oct 27, 2015

Once again in phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ciera @tedks @supertriceratops