Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Replace kRPC #96

Open
ciera opened this issue Sep 30, 2015 · 3 comments
Open

Replace kRPC #96

ciera opened this issue Sep 30, 2015 · 3 comments
Assignees
Labels

Comments

@ciera
Copy link
Contributor

ciera commented Sep 30, 2015

We should replace kRPC with gRPC. This will allow us to remove more kythe code from third-party.

@ciera ciera added the P2 label Sep 30, 2015
@ciera ciera added P1 P2 and removed P2 P1 labels Oct 7, 2015
@ciera ciera added P1 and removed P2 labels Oct 16, 2015
@ciera
Copy link
Contributor Author

ciera commented Oct 16, 2015

Increasing priority; if we're going to change the protocol we should do it before more external analyzers get written.

@ciera
Copy link
Contributor Author

ciera commented Oct 16, 2015

We have several steps to making this work.

  1. Fix up our third party repo and the build rules around them. It's a mess right now. We should use kythe as an example.
  2. Add in grpc by setting GOPATH to thirdparty/go; doing a go get; adding in the BUILD rules needed for all of this.
  3. Make it possible for grpc to generate service stubs from proto. This requires modifying bazel config (plugins=grpc, search for this in kythe for an example) and adding the implicit grpc dependencies. Kythe added this to their proto build rules with has_services flag. We're probably just going to want all of kythe's build rules for grpc.
  4. Switch our code over to using grpc.

@ciera
Copy link
Contributor Author

ciera commented Oct 17, 2015

Part 1 is complete, D145.

@ciera ciera self-assigned this Oct 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant