Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer Unification for Ruby 2.4.0+ #85

Merged
merged 1 commit into from Jun 20, 2017

Conversation

koic
Copy link
Contributor

@koic koic commented Dec 18, 2016

Ruby 2.4.0 unifies Fixnum and Bignum into Integer.

https://bugs.ruby-lang.org/issues/12005

Fix following deprecated warnings in Ruby 2.4.0+.

  • warning: constant ::Fixnum is deprecated
  • warning: constant ::Bignum is deprecated

Thanks.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@koic
Copy link
Contributor Author

koic commented Dec 18, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@hsbt
Copy link

hsbt commented Mar 31, 2017

Any progress? I still faced a lot of warning messages.

@koic
Copy link
Contributor Author

koic commented Apr 11, 2017

Hi @sqrrrl, Thank you for your maintenance. If you don't mind, could you release a new version of signet containing this patch?

@hashwin
Copy link

hashwin commented Jun 20, 2017

Any update on this? Would be great to clear out these warning messages associated with the google-api-ruby-client gem.

@sqrrrl sqrrrl merged commit 7ae73a5 into googleapis:master Jun 20, 2017
@koic koic deleted the integer_unification branch July 13, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants