New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UI design for new googlesitekit-user-input
admin screen
#2040
Comments
IB ✅ |
QA ❌Development using Chrome on the left, Figma on the right. Note - many of the items found or in question are Chrome specific. Browsers Tested:
Question 1:Items to note:
Question 3:Items to note:
Question 4:Items to note:
Question 5:Items to note:
Preview:Items to note:
Negative tests:User is able to tab to next questions and fill out items that are grayed out (note below I was able to type in 'test' within the grayed out 'Other:' fieldUser is able to enter in a value for 'Other:' while also selecting another value then proceeding to the next question. See below, I entered in 'test' into the 'Other:' field then clicked out of the question to the 1st answer and the Next button ungrayed and is able to be clicked to proceed |
Assigning back to @asvinb to review/address. |
Per our previous conversation, @cole10up @asvinb can you open a follow-up issue that points out everything that needs to be modified here? We should address those changes against that new issue then and leave this one untouched so that it's ready for the current release. Since it is not a user-facing feature, there is no reason to block the release based on these changes, especially since they don't block any actual functionality. Afterwards, we can move this to Approval. |
QA ✅Retested: Opened an incognito window and retried the Chrome specific items below:
Created the following issue #2394 to track the remaining items that exist outside of the above that have been proven fixed due to an incognito window. Sending this to Approval per the above direction from @felixarntz |
After #2039, this issue is about actually implementing the UI design for the
googlesitekit-user-input
admin screen (also see #2038) previously created using CSS (and minor alterations of the new components as necessary).Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
googlesitekit-user-input
screen should be implemented per the designs, using the React components implemented as part of Implement base JS components forgooglesitekit-user-input
screen #2039.googlesitekit-user-input
screen #2039. It should be possible to rely on the existing components overall though.Implementation Brief
user-input
in/assets/sass/components/
._googlesitekit-user-input.scss
.QA Brief
The components should be styled as per the designs across all breakpoints.
Changelog entry
googlesitekit-user-input
screen.The text was updated successfully, but these errors were encountered: