Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.22.0 #2473

Closed
aaemnnosttv opened this issue Dec 3, 2020 · 8 comments
Closed

Release 1.22.0 #2473

aaemnnosttv opened this issue Dec 3, 2020 · 8 comments
Assignees
@tofumatt @felixarntz @caseymorrisus @cole10up
Labels
P0 High priority Type: Task Tasks which do not involve engineering
Milestone
Sprint 37

Comments

@aaemnnosttv
Copy link
Collaborator

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added P0 High priority Type: Task Tasks which do not involve engineering labels Dec 3, 2020
@aaemnnosttv aaemnnosttv added this to the Sprint 37 milestone Dec 3, 2020
@eugene-manuilov
Copy link
Collaborator

@felixarntz release looks good to me, but I have found one error during my testing. The error appears after I confirm resetting the plugin and exists in the current production version of the plugin, so it shouldn't block the new release. I have created a new issue for it: #2478.

@eugene-manuilov eugene-manuilov removed their assignment Dec 3, 2020
@eugene-manuilov
Copy link
Collaborator

One more minor thing that I have noticed is that the new release missing the caret icon in the user menu. Not sure if it has been removed intentionally or not.

The current production version:
old

The new release:
new

@felixarntz
Copy link
Member

@eugene-manuilov

@felixarntz release looks good to me, but I have found one error during my testing. The error appears after I confirm resetting the plugin and exists in the current production version of the plugin, so it shouldn't block the new release. I have created a new issue for it: #2478.

You mean it's already in the previous version of the release? Or it's only in the development build? Not sure I understand correctly. If it's a bug that surfaces in production and was not already in the last release, we need to fix it for this one.

One more minor thing that I have noticed is that the new release missing the caret icon in the user menu. Not sure if it has been removed intentionally or not.

That one is intended per the Figma design.

@eugene-manuilov
Copy link
Collaborator

You mean it's already in the previous version of the release? Or it's only in the development build? Not sure I understand correctly. If it's a bug that surfaces in production and was not already in the last release, we need to fix it for this one.

Sorry, I meant that that bug also exists in the 1.21.0.

@aaemnnosttv aaemnnosttv removed their assignment Dec 3, 2020
@benbowler
Copy link
Collaborator

benbowler commented Dec 4, 2020 •
edited

@eugene-manuilov @felixarntz the removal of the caret icon was in the Figma designs for the update of the header date range selector.

@benbowler
Copy link
Collaborator

@felixarntz smoke test passed.

@benbowler benbowler removed their assignment Dec 4, 2020
@kostyalmm
Copy link
Contributor

smoke test passed.

@kostyalmm kostyalmm removed their assignment Dec 4, 2020
@wpdarren
Copy link
Collaborator

wpdarren commented Dec 4, 2020

Smoke test passed but noted an observation in Slack when you disconnect and reset site kit data.

@wpdarren wpdarren removed their assignment Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

@felixarntz felixarntz

@caseymorrisus caseymorrisus

@cole10up cole10up

Labels
P0 High priority Type: Task Tasks which do not involve engineering
Projects
None yet
Milestone
Sprint 37
Development

No branches or pull requests
9 participants
@tofumatt @benbowler @eugene-manuilov @aaemnnosttv @felixarntz @caseymorrisus @cole10up @kostyalmm @wpdarren