New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all Side Kick graphics are the correct versions #3840
Comments
@marrrmarrr @fhollis @eclarke1 which Site Kick graphics is the correct one and for which tab? We display the yellow creature when we have no new ideas, the blue one on the saved ideas tab when we have no saved ideas, and the red one on the drafts tab when we have no drafts. |
@danielgent would you please add an estimate? |
Done @aaemnnosttv ! |
IB ✅ |
@danielgent would you please add a QAB? |
Done @aaemnnosttv 👍 |
QA Update: ✅
|
Bug Description
Incorrect graphic:
Correct graphics:
Emily Clarke3 days ago
@mariya Moeva spotted this one - the Side Kick graphics in the Figma file are not the latest version.
Please see this folder for all latest side kick graphics.
Asana link: https://app.asana.com/0/1200491083500938/1200750635859151
Steps to reproduce
Screenshots
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
idea-hub-empty-draft-ideas.svg
idea-hub-empty-new-ideas.svg
idea-hub-empty-saved-ideas.svg
zero-state-blue.svg
:zero-state-yellow.svg
instead ofidea-hub-empty-new-ideas.svg
zero-state-blue.svg
instead ofidea-hub-empty-saved-ideas.svg
zero-state-red.svg
instead ofidea-hub-empty-draft-ideas.svg
Implementation Brief
assets/svg/
assets/svg/
. The names are also provided in point 2 of the ACThese steps are done in this PR #3868
Test Coverage
Visual Regression Changes
QA Brief
Compare the three stories on storybook's develop branch with main
https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-idea-hub-widgets-dashboardideaswidget--data-unavailable-new
https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-idea-hub-widgets-dashboardideaswidget--data-unavailable-saved
https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-idea-hub-widgets-dashboardideaswidget--data-unavailable-drafts
Check that
develop
shows the new SVG graphics included in the ACChangelog entry
The text was updated successfully, but these errors were encountered: