Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an idea has multiple topics, we need to separate them with a comma or another separator because without a separator it seems like there is one big topic #3857

Closed
simonchampion opened this issue Aug 12, 2021 · 11 comments
Labels
Module: Idea Hub Google Idea Hub module related issues P0 High priority Type: Enhancement Improvement of an existing feature UX Issues that require UX input
Milestone

Comments

@simonchampion
Copy link

simonchampion commented Aug 12, 2021

Bug Description

image

image

image

Please note @Pratheep-lab's comments in Asana: https://app.asana.com/0/1200491083500938/1200749910371621

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Plugin Version [e.g. 22]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The topics that appear above an idea in the Idea Hub widget should have their styling adjusted so that they can be clearly visually separated (in case there are multiple topics).
  • For that purpose, the light-blue background as seen in the last design screenshot above should be used.

Implementation Brief

Using assets/sass/components/idea-hub/_googlesitekit-idea-hub-dashboard-ideas-widget.scss

For the class .googlesitekit-idea-hub__idea--topic, add the following rules

background-color: $c-solitude;
border-radius: 2px;
padding: 1px 6px;

This is done on this open PR - #3867

Test Coverage

  • No changes

Visual Regression Changes

  • No changes

QA Brief

  • Go to the dashboard page.
  • Verify that idea topics have a light-blue background as shown in the last design screenshot above.

Changelog entry

  • Update styles of the topic idea element to have a light-blue background.
@fhollis fhollis added the P0 High priority label Aug 12, 2021
@fhollis fhollis added this to the Sprint 56 milestone Aug 12, 2021
@felixarntz felixarntz self-assigned this Aug 12, 2021
@felixarntz felixarntz added Module: Idea Hub Google Idea Hub module related issues Type: Enhancement Improvement of an existing feature UX Issues that require UX input labels Aug 12, 2021
@felixarntz felixarntz removed their assignment Aug 12, 2021
@danielgent danielgent self-assigned this Aug 13, 2021
@danielgent
Copy link
Contributor

@Pratheep-lab Do you have a design file for this? On Figma or whatever

done-by-eye

I've just done this by eye using the JPG but it's not correct, and I know it'll end up with back-and-forth as we all guess the measurements 😉

@Pratheep-lab
Copy link
Collaborator

@danielgent Sorry if the Figma file was not shared as part of the Asana task. Here is the direct link to it: https://www.figma.com/file/YB79eKcGOwyUjlWG8mjDZA/Prompt-Engine-Idea-Hub?node-id=21108%3A4109
CC: @eclarke1 @felixarntz

@danielgent
Copy link
Contributor

@Pratheep-lab Great stuff!

I don't see the background colour #e8f1fd as an existing variable. I'm not sure if that's a problem on Site Kit though. I can let whoever does the IBR tell me

This is what I've got it looking like. Any comments?

done-by-eye

@danielgent danielgent assigned danielgent and unassigned danielgent Aug 13, 2021
@Pratheep-lab
Copy link
Collaborator

@danielgent Use this color $c-solitude: #e8f0fe; I have updated the designs as well.

@danielgent danielgent removed their assignment Aug 13, 2021
@eugene-manuilov eugene-manuilov self-assigned this Aug 16, 2021
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Aug 16, 2021
@wpdarren wpdarren self-assigned this Aug 16, 2021
@wpdarren
Copy link
Collaborator

QA Update: ❌

@eugene-manuilov the font color is #5f6368 on my test site but on the designs it's #333333. Also, the character spacing appears to be tight. Have to say the font color and character spacing makes the text much easier to read on the Figma.

Verified:

Verified that idea topics have a light-blue background as shown in the screenshot.

image

@danielgent
Copy link
Contributor

@Pratheep-lab The desired text colour #333333 isn't a variable on Site Kit

The closest constants in assets/sass/config/_variables.scss are

$c-cape-cod: #3c4043;
$c-nearblack: #212121;

near-black

cape-cod

I'll go with near-black as @wpdarren complained about contrast, but let me know! 😄

@Pratheep-lab
Copy link
Collaborator

@danielgent near black looks good to me. And yes, the letter spacing needs to be more.

Good catch @wpdarren

@danielgent
Copy link
Contributor

looks now

It looks a lot better now 😄 @wpdarren @Pratheep-lab

This is on this PR @eugene-manuilov #3893 . I'll assign the ticket to you now

@danielgent danielgent removed their assignment Aug 17, 2021
@eugene-manuilov
Copy link
Collaborator

@wpdarren this is ready for another round of QA

@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

  • Verified that idea topics have a light-blue background as shown in the screenshot.

34322323

@wpdarren wpdarren removed their assignment Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Idea Hub Google Idea Hub module related issues P0 High priority Type: Enhancement Improvement of an existing feature UX Issues that require UX input
Projects
None yet
Development

No branches or pull requests

7 participants