New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When an idea has multiple topics, we need to separate them with a comma or another separator because without a separator it seems like there is one big topic #3857
Comments
@Pratheep-lab Do you have a design file for this? On Figma or whatever I've just done this by eye using the JPG but it's not correct, and I know it'll end up with back-and-forth as we all guess the measurements 😉 |
@danielgent Sorry if the Figma file was not shared as part of the Asana task. Here is the direct link to it: https://www.figma.com/file/YB79eKcGOwyUjlWG8mjDZA/Prompt-Engine-Idea-Hub?node-id=21108%3A4109 |
@Pratheep-lab Great stuff! I don't see the background colour This is what I've got it looking like. Any comments? |
@danielgent Use this color $c-solitude: #e8f0fe; I have updated the designs as well. |
IB ✔️ |
QA Update: ❌@eugene-manuilov the font color is #5f6368 on my test site but on the designs it's #333333. Also, the character spacing appears to be tight. Have to say the font color and character spacing makes the text much easier to read on the Figma. Verified: Verified that idea topics have a light-blue background as shown in the screenshot. |
@Pratheep-lab The desired text colour The closest constants in
I'll go with |
@danielgent near black looks good to me. And yes, the letter spacing needs to be more. Good catch @wpdarren |
It looks a lot better now 😄 @wpdarren @Pratheep-lab This is on this PR @eugene-manuilov #3893 . I'll assign the ticket to you now |
@wpdarren this is ready for another round of QA |
Bug Description
Please note @Pratheep-lab's comments in Asana: https://app.asana.com/0/1200491083500938/1200749910371621
Steps to reproduce
Screenshots
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Using
assets/sass/components/idea-hub/_googlesitekit-idea-hub-dashboard-ideas-widget.scss
For the class
.googlesitekit-idea-hub__idea--topic
, add the following rulesThis is done on this open PR - #3867
Test Coverage
Visual Regression Changes
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: