New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure pills for widget contexts that are empty/inactive are not displayed #4289
Labels
P0
High priority
Rollover
Issues which role over to the next sprint
Type: Enhancement
Improvement of an existing feature
Comments
felixarntz
added
P0
High priority
Type: Enhancement
Improvement of an existing feature
labels
Oct 27, 2021
IB ✔️ |
7 tasks
7 tasks
@kuasha420 could you please add QAB? |
QA Update: ✅Verified:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P0
High priority
Rollover
Issues which role over to the next sprint
Type: Enhancement
Improvement of an existing feature
#4053 introduced a pill navigation for the unified dashboard that points to individual widget context "section" with anchor links. Per #4136, widget contexts can contextually be empty ("inactive") though, and in that case the respective pill should not be displayed.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
isWidgetContextActive
selector from Hide any section of the dashboard that has zero widgets #4136. If it is not active, the pill should be skipped/not rendered.default-contexts.js
).CONTEXT_MAIN_DASHBOARD_*
.CONTEXT_ENTITY_DASHBOARD_*
.Implementation Brief
assets/js/component/DashboardNavigation
,useDashboardType
hook to check whether we are on the main dashboard or entity dashboard.CONTEXT_MAIN_DASHBOARD_*
andCONTEXT_ENTITY_DASHBOARD_*
constants fromassets/js/googlesitekit/widgets/default-contexts.js
useDashboardType
, query thecore/widgets
data store via theisWidgetContextActive
selector, passing either theCONTEXT_MAIN_DASHBOARD_*
orCONTEXT_ENTITY_DASHBOARD_*
constant for every pill. Note that every pill is associated with the appropriate context. For e.gCONTEXT_MAIN_DASHBOARD_TRAFFIC
andCONTEXT_ENTITY_DASHBOARD_TRAFFIC
are associate to theTraffic
tab.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: