Change remote-controlled features request to be cron-based

[felixarntz]

In order to run the /site-management/features/ request more regularly, it should be changed to be primarily invoked in a (WP) cron-job. Only if for whatever reason no data is set yet (e.g. right after connecting to the service), the request should be issued on demand.

This is part of a set of 2 issues (and related service enhancements) to make the check more flexible and provide additional criteria for whether to enable a feature or not.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The request to retrieve the remote-controlled active features should be changed to be invoked in a WordPress cron job, running twicedaily.
• While that should be the new "default", the request should still be invoked on demand if no data is set yet for the remote-controlled features.
  • In other words, the current Authentication::filter_features_via_proxy method can probably remain as is - it will most likely not invoke the request though since the data in most situations will already have been populated via the cron hook.
• Similar to now, the request should in any case only be issued if the site is already connected to the service, i.e. has its site credentials.

Implementation Brief

Within includes/Core/Authentication/Authentication.php:

• Extract the following block from filter_features_via_proxy into a new function, called e.g. get_transient_features.
  

  site-kit-wp/includes/Core/Authentication/Authentication.php

  Lines 1321 to 1334 in f584517

  	$features = $this->transients->get( $transient_name );
  	if ( false === $features ) {
  	$features = $this->google_proxy->get_features( $this->credentials );
  	if ( is_wp_error( $features ) ) {
  	$this->transients->set( $transient_name, array(), HOUR_IN_SECONDS );
  	} else {
  	$this->transients->set( $transient_name, $features, DAY_IN_SECONDS );
  	// Update persistent option for 'serviceSetupV2'.
  	if ( isset( $features['serviceSetupV2']['enabled'] ) ) {
  	$this->options->set( $service_setup_v2_option_name, (bool) $features['serviceSetupV2']['enabled'] );
  	}
  	}
  	}

• In the register method, use the wp_schedule_event WP API function to schedule a twicedaily call to get_transient_features.

Test Coverage

• Add PHPUnit test coverage for the new functionality.

QA Brief

• Check if the code meets the AC/IB and that the new PHP Unit Tests are sufficient.
• Visit the SK Dashboard and then check the DB for the new cron job - get_transient_features.

Changelog entry

• Change remote-controlled features request to be cron-based, running twice daily.

[tofumatt]

IB ✅

[hussain-t]

QA Verified ✅

• Check if the code meets the AC/IB and that the new PHP Unit Tests are sufficient.
• Visit the SK Dashboard and then check the DB for the new cron job - get_transient_features.