New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all "Learn More" links to use the new /support/?doc= approach. #5485
Comments
@eugene-manuilov ACs LGTM, however can you make the slugs from that doc all lowercase? This may be by accident anyway, but it would be a bit of a weird convention to have some start with a capital letter. |
Thanks, @felixarntz. Slugs are updated. Moving this ticket to IB. |
IB ✔️ |
QA Update
|
Do you mean the text for these URLs is "Get help" instead of "Learn more"? If so, that is fine. The URLs still work as expected, right?
For these two errors ("URL not part of this site" and "staging") I'd say this can be skipped as the process to trigger that error is very niche and the code for it is exactly the same as the rest of the changes. To be honest I'm not even sure of the exact QA steps to get there right now, but if the rest of the changes worked without issue than this can be QA'd. |
Yes, these 'get help' links also working as expected. |
QA Update ✅
|
Feature Description
We need to update all "Learn More" links in the plugin to use the new approach for support links that requires using
{proxy}/support/?doc={slug}
URLs instead of direct links to the documentation site. This approach will allow us to decouple the plugin codebase from actual documentation pages and shift routing responsibility on the proxy service shoulders.The new "learn more" URLs should be computed using the new
getDocumentationLinkURL
selector introduced in #5423.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
{proxy}/support/?doc={slug}
URLs instead of hardcoded ones.Implementation Brief
Learn more
/Learn more ...
should be updated using thegetDocumentationLinkURL()
selector of theCORE_SITE
store.slug
parameter for thegetDocumentationLinkURL()
selector should be taken from the first column of the spreadsheet that matches the existing hardcoded URLs.Test Coverage
QA Brief
href
values that point directly tohttps://sitekit.withgoogle.com/documentation
. Instead, learn more links should point tohttps://sitekit.withgoogle.com/support?doc=
.Changelog entry
The text was updated successfully, but these errors were encountered: