Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounce Rate Data in wrong format on search traffic widget on Entity Dashboard #5506

Closed
wpdarren opened this issue Jul 5, 2022 · 2 comments
Closed
Labels
Good First Issue Good first issue for new engineers Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Jul 5, 2022

Bug Description

While completing release QA, I noticed on the Entity dashboard that the Bounce Rate on the Search traffic widget is not displayed in the correct format and is missing the percentage character.

Here is the data in 1.77.0 (and 1.78.0)
image

Here is the data in 1.75.0
image

As you can see the bounce rate is 0.6 compared with 60.78% which is how it should be appearing.

Note: Another observation which might require another ticket is that the bounce rate actually appears twice on the Entity dashboard. Once on the Search traffic widget and on the Overall page metrics widget. Is there a reason why this is the case? It's the same data so seems odd to have it twice.

Steps to reproduce

  1. Go to 'Entity dashboard' for a site with data
  2. Scroll down to 'the Search widget and observe bounce rate'
  3. See error

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Bounce rate should be consistently formatted as a percentage in all instances
    • In this instance we've identified an inconsistency on the Entity dashboard, but all instances should be checked for consistency

Implementation Brief

  • In assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/Overview.js:
    • Add the datapointUnit: '%' property for id: 'bounce', to the datablocks array.
    • When rendering the DataBlock element, pass the datapointUnit prop if dataBlock.datapointUnit is set, otherwise keep the prop undefined.

Test Coverage

  • No new tests needed.

QA Brief

  • In addition to verifying the bug is resolved (after performing the Steps to reproduce above), ensure that other data blocks are NOT modified in any way.

Changelog entry

  • Fix the formatting of Bounce Rate on the single page dashboard to always be a percentage.
@wpdarren wpdarren added the Type: Bug Something isn't working label Jul 5, 2022
@aaemnnosttv aaemnnosttv added P1 Medium priority Module: Analytics Google Analytics module related issues Good First Issue Good first issue for new engineers labels Dec 16, 2022
@jimmymadon jimmymadon assigned jimmymadon and unassigned jimmymadon Dec 16, 2022
@techanvil techanvil self-assigned this Dec 19, 2022
@techanvil
Copy link
Collaborator

IB ✅

@techanvil techanvil removed their assignment Dec 19, 2022
@jimmymadon jimmymadon self-assigned this Jan 3, 2023
@jimmymadon jimmymadon removed their assignment Jan 3, 2023
@techanvil techanvil assigned techanvil and unassigned techanvil Jan 3, 2023
@wpdarren wpdarren self-assigned this Jan 3, 2023
@wpdarren
Copy link
Collaborator Author

wpdarren commented Jan 3, 2023

QA Update: ✅

Verified:

  • The bounce rate in the Overall page metrics widget is displaying the correct percentage format.
  • Checked the data between develop and latest release for the same widget to ensure no issues occurred.
  • Checked the data between develop and latest release for all widgets on entity dashboard to ensure no changes occurred.
  • Checked the data between develop and latest release for all widgets on main dashboard to ensure no changes occurred.

image

@wpdarren wpdarren removed their assignment Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants