-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VRT test runner in CI. #6151
Comments
@techanvil would Otherwise this looks good. Please add an estimate and then this is good to go 👍 |
Thanks @aaemnnosttv. Lines 28 to 34 in 597e8cb
I've estimated it as a 7, hopefully erring on the side of caution. |
@techanvil ah yes, of course. SGTM, thanks! |
QA here was done as part of the Code Review, so no further QA needed, so moving this directly to Approval. |
VRT is running in CI again but failing (which was expected here). These will be fixed in #6185. |
Bug Description
At present the VRT workflow is not actually running the tests, and reports a false positive when it runs.
We need to fix this to ensure the tests run, and fix any issues with the tests themselves that emerge as a result of not having run them for a while.
Steps to reproduce
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
-i
flag from thedocker run
command inbin/backstop
.bin/backstop
script will need further tweaking in order to ensure the CI step fails if thedocker run
command fails:docker run
command and exit with a 0 for success or 1 for failure at the end of the file.Test Coverage
QA Brief
QA:Eng:
Note for code reviewers: These steps will only be possible to verify on google/site-kit-wp once the PR has been merged to
develop
. However they can be seen in action on this fork of the repo: techanvil/site-kit-wp, with code changes evident here and a sample test run here.Changelog entry
The text was updated successfully, but these errors were encountered: