-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement “Connect GA” metric tile CTA after Key Metrics widget setup #6263
Comments
ACs here are good 👍🏻 |
Similar to #6265, just an adjustment to naming ( Otherwise looks good, IB ✅ |
QA Update ❌Issue 1 : Font color for link is not consistent with other links color on dashboard and not same as font color mentioned under Figma. Question :
|
@mohitwp Assigning @kuasha420 as he did the execution here. Thanks. |
Thanks, @jimmymadon ! Sorry for the confusion. |
@mohitwp Thank you for sharing your observations. I have filled a follow up PR to fix this. See the discussion on slack for more detail on it, specially regarding accessibility.
Cheers. |
QA Update
|
Just a quick summary based on our discussion in Slack of when to show the Connect GA4 CTA: 0 metrics rely on GA4 => Do nothing. |
QA Update ✅
|
Feature Description
If one or two selected metrics within the Key Metrics widget area are from GA4, but GA4 is disconnected, then a new CTA tile should be rendered to encourage the user to reconnect the module.
Refer to the relevant section in the design doc for additional context.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
ConnectGA4TileCTA
component in the same directory Scaffold Key metrics Setup CTA on Main Dashboard #6209 is implemented.assets/svg/graphics/analytics.svg
as the image.p
tag per the Figma design. The text should be translated.Link
component per the Figma design. The text should be translated. TheonClick
callback should follow a similar implementation as theSetupModule
component:site-kit-wp/assets/js/components/settings/SetupModule.js
Lines 57 to 82 in 43c4364
null
if the GA4 module is connected using theisModuleConnected
selector.getKeyMetrics
selector, the component should check if any of the selected metrics are from GA4. If so, it should render theCTA
component. Otherwise, it should rendernull
.ConnectGA4TileCTAWidget
component in the same directory Scaffold Key metrics Setup CTA on Main Dashboard #6209 is implemented.Widget
andWidgetNull
components as props.ConnectGA4TileCTA
component within theWidget
component if the following conditions are met:isModuleConnected
selector.getKeyMetrics
selector.WidgetNull
component.ConnectGA4TileCTAWidget
component.Register the widget
ConnectGA4TileCTAWidget
component in theKeyMetrics
widget area once Register the new key metric widgets #6313 is merged.width
should beQUARTER
.wrapWidget
should befalse
.priority
should be1
.modules
should be['analytics']
.Test Coverage
ConnectGA4TileCTA
component.QA Brief
ga4Reporting
anduserInput
feature flags are enabled.widgetSlugs
in the above snippet. ie.Changelog entry
The text was updated successfully, but these errors were encountered: