-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Ad Blocker Detection related setting in AdSense Settings view #6961
Labels
Exp: SP
Module: AdSense
Google AdSense module related issues
P0
High priority
Type: Enhancement
Improvement of an existing feature
Comments
kuasha420
added
P0
High priority
Type: Enhancement
Improvement of an existing feature
Module: AdSense
Google AdSense module related issues
labels
Apr 23, 2023
AC ✅ |
IB ✅ |
18 tasks
QA Update: ✅Verified:
Note: there are a few differences with the UI - i.e. as mentioned the bold text in the QAB plus the titles are in bold on Storybook but not in figma designs. This is understood to be expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Exp: SP
Module: AdSense
Google AdSense module related issues
P0
High priority
Type: Enhancement
Improvement of an existing feature
Feature Description
Once an user completes the Ad blocking recovery tag setup, the status of the recovery tag placement should be shown in the Settings view of AdSense Module settings instead of the "Setup Ad Blocking Recovery CTA", as seen in Figma design.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
adBlockingRecoverySetupStatus
is not an empty string), the status of the recovery tag placement should appear in the AdSense Settings View.Implementation Brief
In
assets/js/modules/adsense/components/settings/SettingsView.js
:adBlockingRecoverySetupStatus
using thegetAdBlockingRecoverySetupStatus
selector.adBlockingRecoverySetupStatus
is an empty string, rendernull
.adBlockingRecoverySetupStatus
istag-placed
render the following as the last meta item:googlesitekit-settings-module__meta-items
), for example,Excluded from ads
.h5
tag with the classgooglesitekit-settings-module__meta-item-type
should have theAd blocking recovery
text.p
tag with the classgooglesitekit-settings-module__meta-item-data
should have the textAd blocking recovery tag is placed
.createInterpolateElement
, add anotherh5
tag with the classgooglesitekit-settings-module__meta-item-type
with the textAd blocking recovery only works if you’ve also created and published a recovery message in AdSense. Configure your message
.Configure your message
should use theLink
component that takes the user to their AdSense console's Privacy and Messaging section.getServiceURL
selector. Construct the path by concatenating the Adsense account ID and the/privacymessaging/ad_blocking
string. See:site-kit-wp/assets/js/components/notifications/AdBlockingRecoveryNotification.js
Lines 55 to 59 in 5668847
adBlockingRecoverySetupStatus
issetup-confirmed
render the meta item elements as above with following changes:p
tag with the classgooglesitekit-settings-module__meta-item-data
should have the textAd blocking recovery tag is not placed
.h5
tag.stories/module-adsense-settings.stories.js
, add stories for the new meta itemAd blocking recovery
.Test Coverage
QA Brief
This can't be tested on a live site yet because the feature cannot be fully set up. Instead, test the UI in storybook.
Changelog entry
The text was updated successfully, but these errors were encountered: