Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error on setup screen #808

Closed
swissspidy opened this issue Nov 7, 2019 · 3 comments
Closed

JS error on setup screen #808

swissspidy opened this issue Nov 7, 2019 · 3 comments
Labels
P1 Medium priority Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Contributor

swissspidy commented Nov 7, 2019

Bug Description

When resetting the plugin and opening the setup screen, there is a JS error in the console.

Steps to reproduce

  1. Reset Site Kit
  2. Open Site Kit setup screen
  3. See error

Screenshots

Screenshot 2019-11-07 at 11 08 18

Additional Context

  • PHP Version: 7.2
  • Browser: Chrome on macOS
  • Plugin Version: 1.0.1

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • There should be no JS console errors on the setup screen after resetting the plugin.

Implementation Brief

Changelog entry

@ThierryA ThierryA added P1 Medium priority Type: Bug Something isn't working labels Nov 7, 2019
@tofumatt tofumatt self-assigned this Nov 11, 2019
@tofumatt
Copy link
Collaborator

I wasn't able to reproduce this bug in Firefox or Chrome on Mac OS using either the latest develop branch or the 1.0.1 tag, as reported here when run using npm run watch. I'm going to try building a zip and seeing if I can recreate the error, but I also don't find reference to alignToolTip anywhere in our codebase or the property .top anywhere in our codebase. I tried with both the developer set up flow and the proxy set up flow. Here's me resetting in Chrome:

2019-11-11 21 25 50

@tofumatt
Copy link
Collaborator

I just installed the release ZIP of 1.0.1 on a new Jurassic Ninja site, followed the steps here, and did not get the error.

I don't think there's an issue with the plugin set up screen; I'm not able to reproduce the issue here.

@tofumatt
Copy link
Collaborator

I'm still not able to reproduce this locally or on a new site. If this is still happening and you can provide specific steps to reproduce we should open this back up, but closing for now as I can't reproduce the issue and haven't seen other reports of it.

@tofumatt tofumatt removed their assignment Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants