New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA events for "Top Earning Pages" success notification #8214
Comments
(Moving to stalled because this component doesn't exist yet.) |
@tofumatt is it maybe possible to add dependencies here? I don't know if the tickets for these component's exist already or not. In case they don't, can we add them later. |
This comment was marked as resolved.
This comment was marked as resolved.
Leaving this one in AC with me until we move #8238 into IB, because the events fired will depend on how many (1 or 2) CTAs there are 🙂 |
IB ✔️ |
QA Update: ✅Verified: When the AdSense + GA connected notification is shown the following trackEvent calls are made:
|
Feature Description
GA events (eg.
trackEvent
calls) should be added to the new "Top Earnings Pages" notification that appears after successful AdSense + GA4 integration/connection. There should be one when a user views the notification one when they click the "Show me" CTA button in the notification, and another when the user dismisses the notification with the "Got it" button.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
trackEvent
calls should be made:trackEvent( `{viewContext}_top-earning-pages-success-notification`, 'view_notification' )
when the notification is rendered and shown to the usertrackEvent( `{viewContext}_top-earning-pages-success-notification`, 'confirm_notification' )
when the user clicks the "Got it"/primary CTACTA widget screenshot:
Implementation Brief
trackEvent( `{viewContext}_top-earning-pages-success-notification`, 'view_notification' )
tosite-kit-wp/assets/js/components/notifications/GA4AdSenseLinkedNotification.js
Line 46 in 902f409
null
, likely in auseEffect
that should only calltrackEvent
once per page load.trackEvent( `{viewContext}_top-earning-pages-success-notification`, 'confirm_notification' )
to theonClick
function of the primary button atsite-kit-wp/assets/js/components/notifications/GA4AdSenseLinkedNotification.js
Lines 212 to 214 in 902f409
site-kit-wp/assets/js/components/notifications/GA4AdSenseLinkedNotification.js
Lines 133 to 135 in 902f409
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: