Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA events for "Top Earning Pages" success notification #8214

Closed
2 tasks
tofumatt opened this issue Feb 2, 2024 · 7 comments
Closed
2 tasks

Add GA events for "Top Earning Pages" success notification #8214

tofumatt opened this issue Feb 2, 2024 · 7 comments
Labels
javascript Pull requests that update Javascript code Module: Analytics Google Analytics module related issues P1 Medium priority

Comments

@tofumatt
Copy link
Collaborator

tofumatt commented Feb 2, 2024

Feature Description

GA events (eg. trackEvent calls) should be added to the new "Top Earnings Pages" notification that appears after successful AdSense + GA4 integration/connection. There should be one when a user views the notification one when they click the "Show me" CTA button in the notification, and another when the user dismisses the notification with the "Got it" button.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When the AdSense + GA connected notification is shown (see Show a small notification when AdSense + GA4 accounts are detected as linked #8238), the following trackEvent calls should be made:
    • trackEvent( `{viewContext}_top-earning-pages-success-notification`, 'view_notification' ) when the notification is rendered and shown to the user
    • trackEvent( `{viewContext}_top-earning-pages-success-notification`, 'confirm_notification' ) when the user clicks the "Got it"/primary CTA

CTA widget screenshot:

Screenshot 2024-02-19 at 23 30 50

Implementation Brief

Test Coverage

  • We're lacking track event test coverage code I think, so adding tests here is a bit out-of-scope.

QA Brief

Changelog entry

  • Add Analytics events to AdSense + Analytics success notification.
@tofumatt tofumatt added P1 Medium priority Module: Analytics Google Analytics module related issues javascript Pull requests that update Javascript code labels Feb 2, 2024
@tofumatt tofumatt self-assigned this Feb 2, 2024
@bethanylang bethanylang added the Next Up Issues to prioritize for definition label Feb 2, 2024
@tofumatt
Copy link
Collaborator Author

tofumatt commented Feb 2, 2024

(Moving to stalled because this component doesn't exist yet.)

@ivonac4
Copy link
Collaborator

ivonac4 commented Feb 2, 2024

@tofumatt is it maybe possible to add dependencies here? I don't know if the tickets for these component's exist already or not. In case they don't, can we add them later.

@tofumatt

This comment was marked as resolved.

@tofumatt
Copy link
Collaborator Author

tofumatt commented Feb 8, 2024

@ivonac4 I've updated this as blocked by #8238, now that we have that filed 😄

@ivonac4 ivonac4 added Next Up Issues to prioritize for definition and removed Next Up Issues to prioritize for definition labels Feb 16, 2024
@tofumatt
Copy link
Collaborator Author

Leaving this one in AC with me until we move #8238 into IB, because the events fired will depend on how many (1 or 2) CTAs there are 🙂

@tofumatt tofumatt removed their assignment Feb 19, 2024
@bethanylang bethanylang removed the Next Up Issues to prioritize for definition label Feb 21, 2024
@tofumatt tofumatt self-assigned this Feb 21, 2024
@ivonac4 ivonac4 added the Next Up Issues to prioritize for definition label Mar 6, 2024
@tofumatt tofumatt removed their assignment Mar 7, 2024
@eugene-manuilov eugene-manuilov self-assigned this Mar 12, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Mar 12, 2024
@ivonac4 ivonac4 removed the Next Up Issues to prioritize for definition label Mar 13, 2024
@derweili derweili self-assigned this Mar 13, 2024
@derweili derweili removed their assignment Mar 13, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Mar 13, 2024
@wpdarren wpdarren self-assigned this Mar 20, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

When the AdSense + GA connected notification is shown the following trackEvent calls are made:

  • trackEvent( {viewContext}_top-earning-pages-success-notification, 'view_notification' ) when the notification is rendered and shown to the user
  • trackEvent( {viewContext}_top-earning-pages-success-notification, 'confirm_notification' ) when the user clicks the "Got it" CTA.
Screenshots

image
image

@wpdarren wpdarren removed their assignment Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Analytics Google Analytics module related issues P1 Medium priority
Projects
None yet
Development

No branches or pull requests

7 participants