Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create conditional dashboard CTA for Consent Mode #8279

Closed
2 tasks
aaemnnosttv opened this issue Feb 19, 2024 · 4 comments
Closed
2 tasks

Create conditional dashboard CTA for Consent Mode #8279

aaemnnosttv opened this issue Feb 19, 2024 · 4 comments
Labels
P0 High priority QA: Eng Requires specialized QA by an engineer Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Feb 19, 2024

Feature Description

A new dashboard notification should be created to surface awareness of Consent Mode for users who are configuring Site Kit to place an Ads conversion ID. This notification should only be shown if consent mode is not enabled.

The primary CTA should enable consent mode and navigate to the Admin Settings tab of the settings screen in case the user needs to take further action.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A Consent Mode setup CTA banner should be shown on the main and entity dashboard.
  • This should follow the first iteration of the Figma design.
  • It should appear while Consent Mode is disabled and the user hasn't dismissed the banner.
  • The primary CTA should enable Consent Mode, dismiss the banner and navigate to the Settings screen.
  • The dismissal CTA should dismiss the banner. It should then be shown again after two weeks, for a maximum of three dismissals. The final showing of the banner will have the dismissal CTA text updated to "Don't show again". Actioning the CTA again will dismiss the banner permanently.

Implementation Brief

Test Coverage

  • Add to Storybook with a VRT scenario.

QA Brief

  • Enable the consentMode feature flag, ensure that the Consent Mode enabled setting is false and the Ads Conversion ID is set.
  • Verify that the Consent Mode setup banner is implemented and works correctly as per the AC.
  • Refer to:
  • Note that when the primary CTA is clicked, a spinner will be shown in the button while Consent Mode is enabled, after which the browser will navigate to the Admin Settings tab on the Settings screen.
  • In order to test the multiple dismissals, please refer to the QAB for Implement additional dismissal requirements for Ad Blocking Recovery Widget #7316. Upon review, it turns out the PR to make prompts work with the reference date was not merged, so the non-QA:Eng part of the QAB is not accurate.

Please note that this change does introduce a slight glitch - when refreshing the dashboard, the page will not always scroll to the widget context that was previously scrolled into view. This is a known issue that doesn't need to block the release. Update: Actually, I, @techanvil, have since tested this on InstaWP and TasteWP sites and the glitch isn't occurring. Seems only to be happening on my local dev environment, so maybe a non-issue, but one I will keep an eye on.

QA:Eng:

Changelog entry

  • Create conditional dashboard CTA for Consent Mode.
@aaemnnosttv aaemnnosttv added P0 High priority Type: Enhancement Improvement of an existing feature labels Feb 19, 2024
@techanvil techanvil assigned techanvil and unassigned techanvil Feb 21, 2024
@techanvil techanvil self-assigned this Mar 4, 2024
@techanvil
Copy link
Collaborator

This was moved directly to execution so as not to block the progress toward our hard delivery target for Consent Mode.

@techanvil techanvil added the QA: Eng Requires specialized QA by an engineer label Mar 5, 2024
@techanvil techanvil removed their assignment Mar 5, 2024
@mohitwp mohitwp self-assigned this Mar 5, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Mar 6, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified CTA for consent mode banner.
  • Verified A Consent Mode setup CTA banner shown on the main and entity dashboard.
  • Verfied this follow the first iteration of the Figma design.
  • Verified appear while Consent Mode is disabled and the user hasn't dismissed the banner.
  • Verified primary CTA should enable Consent Mode, dismiss the banner and navigate to the Settings screen.
  • Verified 'Learn more' link navigates user to Site kit documentation page.
  • Verified when thhe Maybe later link is clicked then the CTA banner s disappear and a tooltip display.

image

View Only Dashboard

image

Entity Dashboard

image

Other Admin

image

Larger Desktop View

image

Mobile View :

image

Tablet View

image

Primary CTA

Recording.805.mp4

Maybe later CTA

Recording.806.mp4

@mohitwp
Copy link
Collaborator

mohitwp commented Mar 6, 2024

This is now ready for QA:Eng review to test the multiple dismissals.

@mohitwp mohitwp removed their assignment Mar 6, 2024
@tofumatt tofumatt self-assigned this Mar 6, 2024
@tofumatt
Copy link
Collaborator

tofumatt commented Mar 6, 2024

QA ✅ from me as well 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority QA: Eng Requires specialized QA by an engineer Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants