Tagmanager error:"Not found or permission denied." console error showing when user selects different tag manager a/c.

[mohitwp]

Bug Description

On selecting different tag manager a/c from drop down during Tag manager set up or after set up under settings throw console error.
googlesitekit-api-6b06a5c9b165bf7e28a4.js:3 Google Site Kit API Error method:GET datapoint:live-container-version type:modules identifier:tagmanager error:"Not found or permission denied."

It is confusing because when I selected one a/c as you can see in below screenshots. No console error appear. After selecting another a/c when I selected that a/c again then console error appeared for the same a/c.

Steps to reproduce

1. Set up tag manger.
2. Open console and during set up change tag manager a/c.
3. See error.

OR

1. Set up tag manger.
2. After set up open tag manager settings in edit mode.
3. Select different tag manager a/c from drop down.
4. See error.
5. Clear console while switching a/c.

Screenshots

Recording.787.mp4

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• No console errors should be raised when switching selected accounts in the setup or settings screens for Tag Manager

Implementation Brief

The problem seems to be that the request for the live container version is triggered as soon as the new accountID is set, but the old internalContainerID is still set.

See

• Clarify the cause of "asynchronously handled actions" dispatched from a function that has effectively awaited. #6818

• site-kit-wp/assets/js/modules/analytics-4/datastore/properties.js

  Lines 500 to 505 in 6ea9e69

  	// Note that when plain actions are dispatched in a function where an await has occurred (this can be a regular async function that has awaited, or a generator function
  	// action that yields to an async action), they are handled asynchronously when they would normally be synchronous. This means that following the usual pattern of dispatching
  	// individual setter actions for the `googleTagAccountID`, `googleTagContainerID` and `googleTagID` settings each resulted in a rerender of the
  	// GoogleTagIDMismatchNotification component, thus resulting in an erroneous call to the GET:container-destinations endpoint with mismatched settings. To mitigate this, we
  	// dispatch a single action here to set all these settings at once. The same applies to the `setSettings()` call above.
  	// See issue https://github.com/google/site-kit-wp/issues/6784 and the PR https://github.com/google/site-kit-wp/pull/6814.

• Update selectAccount to set the accountID and reset other IDs all at once using setSettings instead of individual setters
• Finish (if necessary) and merge Set all IDs at once when selecting account. #8318

Test Coverage

• No changes expected

QA Brief

• Open the Browser Console.
• Select a Tag Manager account, then select a different account during setup or on the settings edit screen.
• There should be no "Not found or permission denied." console error.

Changelog entry

• Fix bug that caused browser console error to appear when changing Tag Manager account in Tag Manager setup/settings.

[eugene-manuilov]

IB ✔️

[kelvinballoo]

QA Update ✅

This is verified good as follows:

• Tested on MacOS Ventura Chrome on WP 6.4.3 and both PHP 8.0 and PHP 7.4
• Tested on MacOS Ventura Firefox, Safari
• Results are as expected with no console errors when updating the different Gtags
• Saving a new tag also doesn't result in any error.
• Video is attached for reference

Moving this ticket to 'Approval' column.

Video Reference

Screen.Recording.2024-04-02.at.18.23.52.mov