Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Set up Ads Module with Ads Blocker Enabled #8461

Closed
1 task
wpdarren opened this issue Apr 2, 2024 · 2 comments
Closed
1 task

Unable to Set up Ads Module with Ads Blocker Enabled #8461

wpdarren opened this issue Apr 2, 2024 · 2 comments
Labels
Module: Ads Google Ads module related issues Type: Bug Something isn't working

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Apr 2, 2024

Bug Description

When the user has an AdBlocker enabled (either installed locally or on a browser extension) they are unable to set up Ads Module. When it's enabled a message appears when the Complete setup CTA is enabled. The error is not user-friendly: Error: You are probably offline. and additional errors appear in the console.

Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
googlesitekit-api-1f086b18588694520d28.js:3 Google Site Kit API Error method:POST datapoint:settings type:modules identifier:ads error:"You are probably offline." (anonymous) @ googlesitekit-api-1f086b18588694520d28.js:3
ads-3.mp4

Steps to reproduce

  1. Enable an AdBlocker (e.g. AdBlock chrome extension)
  2. Make sure adsModule feature flag is enabled.
  3. Go to Connect More Services tab in Site Kit Settings
  4. Setup the Ads Module.
  5. Enter a Conversion Tracking ID and click the Complete setup CTA button.
  6. See error on screen and in console.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@wpdarren wpdarren added Module: Ads Google Ads module related issues Type: Bug Something isn't working labels Apr 2, 2024
@adamdunnage
Copy link
Collaborator

Just adding here that this also breaks the migration of the conversion ID to the new Ads module. You can see this in the recording (see at 1:15) I captured with an Ad Blocker active in my browser. When using a site that hasn't yet had the adsModule feature flag switched on, follow these steps:

  1. Ensure there is an Ads conversion ID entered via the Analytics module field.
  2. Switch on the adsModule feature flag and select the tester plugin develop branch.
  3. Navigate to Site Kit > Settings but DO NOT open the Analytics settings.
  4. Go to Connect More Services to check that the Ads module is available to connect but again DO NOT select this.
  5. Navigate back to Connected Services and open the Analytics settings.

@bethanylang
Copy link
Collaborator

As noted in Slack, closing this as wontfix because we unfortunately cannot do anything to make setup work while an ad blocker is present. However, we can mitigate by blocking users from starting Ads setup if an ad blocker is detected (similar to the AdSense setup), which we will create a separate issue for.

@bethanylang bethanylang closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants