-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ads module to conditionally require adwords scope #8565
Labels
Module: Ads
Google Ads module related issues
P0
High priority
PHP
Squad 1 (Team S)
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Comments
aaemnnosttv
added
P0
High priority
Type: Enhancement
Improvement of an existing feature
Module: Ads
Google Ads module related issues
labels
Apr 15, 2024
bethanylang
added
Squad 1 (Team S)
Issues for Squad 1
Next Up
Issues to prioritize for definition
labels
Apr 16, 2024
ACs here look good, moving to IB 👍🏻 |
6 tasks
QA Update ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Module: Ads
Google Ads module related issues
P0
High priority
PHP
Squad 1 (Team S)
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Feature Description
The PAX application requires an OAuth token with the Adwords scope (
https://www.googleapis.com/auth/adwords
) granted.Since this is only relevant to request + keep when using PAX, it should be requested on-demand and then treated as a required scope so long as Ads is connected via PAX.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
https://www.googleapis.com/auth/adwords
scope should be conditionally required by the Ads module when theadsPax
feature is enabledextCustomerID
is set, it should be generally required by the moduleImplementation Brief
Module_With_Scopes
interface + use theModule_With_Scopes_Trait
traitregister_scopes_hook
toregister
get_scopes
method as follows:adsPax
feature is enabled, conditionally return the adwords scope if the scope is already granted, orextCustomerID
is set/validTest Coverage
googlesitekit_auth_scopes
filter for assertionsQA Brief
adsPax
feature flaggooglesitekit.data.select('core/user').getGrantedScopes()
, verify you see adwords scope in the outputted listChangelog entry
The text was updated successfully, but these errors were encountered: