Add Plugin Integration for Mailchimp #8571
Labels
P0
High priority
Squad 1 (Team S)
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Feature Description
Mailchimp conversion events should be supported in the new conversion event tracking infrastructure.
See implementation and class design and plugin specific notes section in the design doc
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
submit_lead_form
should be tracked.Implementation Brief
Google\Site_Kit\Core\Conversion_Tracking\Conversion_Event_Providers\Mailchimp
Google\Site_Kit\Core\Conversion_Tracking\Conversion_Events_Provider
interface.conversion_provider_slug
with a value, saymailchimp
is_active
- check ifMC4WP_VERSION
constant is definedtrue
if it isfalse
get_event_names
- return an associative array contain one stringsubmit_lead_form
register_script
- Instantiate theGoogle\Site_Kit\Core\Assets\Script
class and register the script, leveraging the execution argument for deferring the script. It should return the Script instance.Script
class heresite-kit-wp/includes/Core/Assets/Assets.php
Lines 441 to 449 in fd7efe4
mc4wp-forms-api
script as dependency'execution' => 'defer'
gsk-cep-{$this->conversion_provider_slug}
Script
instanceassets/js/event-providers/mailchimp.js
conversionEventProviders.config.js
webpack partial added in Add Webpack Partial That Will Build Conversion Providers Specific JS Files #8531yield conversionEventProviders( mode );
is run in the mainwebpack.config.js
config (it is commented out while there are no entry points)Conversion_Events
class property added in Add MainConversion_Tracking
Class #8528Test Coverage
get_event_names
method returns correct event names, andregister_script
returns script instance with proper handle. Alsois_active
method can be confirmed by defining the plugin constantQA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: