Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging displayed to users who don't have access to a newly connected GTM property, or don't display a message at all #8597

Open
1 task
jamesozzie opened this issue Apr 22, 2024 · 2 comments
Labels
Module: Tag Manager Google Tag Manager module related issues Type: Enhancement Improvement of an existing feature Type: Support Support request

Comments

@jamesozzie
Copy link
Collaborator

Bug Description

If a secondary user connects Tag Manager, using a GTM account or property that other users don't have access to, the messaging shown to other users could be improved. It is also very likely that we don't need any message to be displayed, given there is no data shown from Tag Manager on the Dashboard

In short - as the issue is permissions related, don't indicate that the issue is that users didn't grant permissions.

If we are to changing the messaging, see below (note that this may be possible as the messaging may be similar across all modules)

-Site Kit can’t access the relevant data from Tag Manager because you haven’t granted all permissions requested during setup. To use Site Kit, you’ll need to redo the setup for Tag Manager – make sure to approve all permissions at the authentication stage.
+Site Kit can’t access the relevant data from Tag Manager because you haven’t granted all permissions requested during setup, or you don't have access to the connected property. You’ll need to redo the setup for Tag Manager – make sure to approve all permissions at the authentication stage.

image

I feel we can remove the message altogether for Tag Manager, and modules that don't feature any data on the Dashboard (ie. Possibly Google Ads).

Steps to reproduce

  1. Set up SK on a site (admin1)
  2. Logout of wp-admin
  3. Login to wp-admin using another administrator account (admin2)
  4. Connect Tag Manager but use a different Google account. Be sure to select a GTM account or property that other admins don't have access to
  5. Logout of wp-admin
  6. Login back into wp-admin, this time using the original admin account that set up the plugin (admin1)
  7. The error appears, which could be improved or removed

Note that there is a second GH issue opened (#8596) which is related, as it's permissions related with GTM for the same scenario (one admin doesn't have access to the property set up another admin)

Additional Context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@jamesozzie jamesozzie added Type: Bug Something isn't working Type: Support Support request Type: Enhancement Improvement of an existing feature Module: Tag Manager Google Tag Manager module related issues labels Apr 22, 2024
@jamesozzie
Copy link
Collaborator Author

Note that the same applies in the case of GA, whereby a secondary administrator may set up GA (not the original user who set up SK). We should probably hide this banner. Completing set up by following the CTA in the banner does remove this banner, but the permissions errors remain (the pink permissions errors in the screenshot below).

image

@aaemnnosttv aaemnnosttv removed the Type: Bug Something isn't working label Apr 25, 2024
@aaemnnosttv
Copy link
Collaborator

As discussed earlier, this issue isn't really specific to GTM but relevant for any module which doesn't have a visible presence on the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Tag Manager Google Tag Manager module related issues Type: Enhancement Improvement of an existing feature Type: Support Support request
Projects
None yet
Development

No branches or pull requests

2 participants