Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate <ConversionTrackingToggle /> Component Into Ads and GA4 <SettingsEdit /> Components #8618

Open
1 task
10upsimon opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Module: Analytics Google Analytics module related issues Next Up Issues to prioritize for definition Squad 1 (Team S) Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Apr 25, 2024

Feature Description

With the Conversion Tracking UI toggle component and associated settings/datastore now complete (see #8616), the toggle is ready to be integrated into both the settings edit area of the Ads module, as well as the GA4 module.

This issue focusses on the edit view of the settings area of said modules, i.e the <SettingsEdit /> component of each module.

The enabled/disabled status for Conversion Tracking should be displayed in UI toggle form based on the state of the toggle (i.e if conversion tracking enabled (true) or disabled (false) via the applicable datastore selector). Toggling the element on or off will result in the applicable Conversion Tracking setting being updated, and UI reflected as such.

Please reference the "Conversion Event Tracking Toggle & Settings" area of the design doc for more detailed information.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • ConversionTrackingToggle component implemented in 8616 should be added to the SettingsEdit component of Ads and Analytics modules

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@10upsimon 10upsimon added javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Module: Analytics Google Analytics module related issues Squad 1 (Team S) Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Apr 25, 2024
@eclarke1 eclarke1 added the Next Up Issues to prioritize for definition label Apr 30, 2024
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Apr 30, 2024
@10upsimon 10upsimon self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Module: Analytics Google Analytics module related issues Next Up Issues to prioritize for definition Squad 1 (Team S) Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants