Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PAX integrator #8852

Closed
2 tasks done
aaemnnosttv opened this issue Jun 10, 2024 · 2 comments
Closed
2 tasks done

Update PAX integrator #8852

aaemnnosttv opened this issue Jun 10, 2024 · 2 comments
Labels
Module: Ads Google Ads module related issues P1 Medium priority Team S Issues for Squad 1 Type: Infrastructure Engineering infrastructure & tooling

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Jun 10, 2024

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The PAX integrator script + types should be updated to 1.0.9

Implementation Brief

  • Update the src of the googlesitekit-ads-pax-integrator Script within Ads::setup_assets
  • Update the google-pax-sdk version in package.json to match, and update

Test Coverage

  • No changes expected

QA Brief

  • On a site with PAX already set up, the PAX integration should continue to work without issue. No specific QA is needed.

Changelog entry

  • Update PAX integration library to latest version.
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling blocked upstream Issues which are blocked by external work Module: Ads Google Ads module related issues Team S Issues for Squad 1 labels Jun 10, 2024
@binnieshah binnieshah removed the blocked upstream Issues which are blocked by external work label Jun 11, 2024
@tofumatt tofumatt self-assigned this Jun 11, 2024
@tofumatt
Copy link
Collaborator

IB ✅

@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Jun 11, 2024
@tofumatt tofumatt added blocked upstream Issues which are blocked by external work and removed blocked upstream Issues which are blocked by external work labels Jun 11, 2024
@tofumatt tofumatt removed their assignment Jun 11, 2024
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Jun 12, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Jun 13, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified on a site with PAX already set up, the PAX integration continue to work without issue.
  • Setup Ads module in PAX manner on latest environment.
  • Successfully completed PAX setup.
  • Switched to dev environment.
  • Verified Ads module not disconnected.
  • Disconnected ads module.
  • Reconnected Ads module.
  • Verified PAX setup shows completed and ads module reconnected successfully with already created conversion ID.
Recording.1080.mp4

</details.

@mohitwp mohitwp removed their assignment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P1 Medium priority Team S Issues for Squad 1 Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

6 participants