Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct title font for the Consent Mode Setup CTA Banner #8898

Closed
2 tasks
techanvil opened this issue Jun 18, 2024 · 2 comments
Closed
2 tasks

Use the correct title font for the Consent Mode Setup CTA Banner #8898

techanvil opened this issue Jun 18, 2024 · 2 comments
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Jun 18, 2024

Feature Description

The Consent Mode Setup CTA Banner has been implemented with a title font of Google Sans Text. However, as per the Figma design, it should be Google Sans Display.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The title font for the Consent Mode Setup CTA Banner should be Google Sans Display.

Implementation Brief

Test Coverage

  • Update VRT reference images as needed.

QA Brief

  • Enable a VPN so your request is coming from an EU country (for instance, Germany)
  • Set up Site Kit on a new site
  • The Consent Mode title ("Enable Consent Mode to preserve…") should be using Google Sans Display

Changelog entry

  • N/A
@techanvil techanvil added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Jun 18, 2024
@techanvil techanvil changed the title Use the correct title font for the Consent Mode Setup CTA Banners Use the correct title font for the Consent Mode Setup CTA Banner Jun 18, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jun 18, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jun 18, 2024
@binnieshah binnieshah added Next Up Issues to prioritize for definition Team S Issues for Squad 1 and removed Next Up Issues to prioritize for definition labels Jun 19, 2024
@tofumatt tofumatt self-assigned this Jul 1, 2024
@tofumatt tofumatt removed their assignment Jul 2, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Jul 3, 2024
@mohitwp mohitwp self-assigned this Jul 8, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Jul 8, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified title font for the Consent Mode Setup CTA Banner is now Google Sans Display.

image

@mohitwp mohitwp removed their assignment Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants