Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "timezone" argument to custom the compute of human_timestamp #40

Closed
bkamin29 opened this issue Sep 28, 2020 · 2 comments
Closed

Add "timezone" argument to custom the compute of human_timestamp #40

bkamin29 opened this issue Sep 28, 2020 · 2 comments
Labels
feature New feature or request

Comments

@bkamin29
Copy link

bkamin29 commented Sep 28, 2020 •
edited

slo-generator export in BQ a human_timestamp.
By default the timezone is Europe/Paris.
We have to add an argument to be able to custom this timezone
Default have to be UTC

Created from GoogleCloudPlatform/professional-services#522
@bkamin29 bkamin29 mentioned this issue Sep 28, 2020
Closed
@ocervell
Copy link
Collaborator

Hey @bkamin29 , I've merged #43 which addresses part of this issue: basically it gives you a human timestamp based on where slo-generator runs - do you think there should still be an option to manually set ?

@ocervell ocervell changed the title Add "timeZone" argument to custom the compute of human_timestamp Add "timezone" argument to custom the compute of human_timestamp Sep 28, 2020
@ocervell ocervell added the feature New feature or request label Sep 28, 2020
@bkamin29
Copy link
Author

We can keep this issue but with #43 it's not a priority no ?
In my case #43 is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocervell @bkamin29