Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(support) TypeORM #43

Open
feihan opened this issue Feb 2, 2021 · 5 comments
Open

feat(support) TypeORM #43

feihan opened this issue Feb 2, 2021 · 5 comments

Comments

@feihan
Copy link

feihan commented Feb 2, 2021

Hi,

this is a great library.
Unfortunately we are mostly using Typeorm (https://typeorm.io/) which is not supported yet.
I think this is one of the most important node.js ORMs currently.

If anyone is interested, i can try to help out as much as i can.

Thanks

@balachandr
Copy link
Collaborator

balachandr commented Feb 23, 2021

@feihan , we will be happy to work with you on getting Typeorm done. Let us know if you would like to contribute.

@feihan
Copy link
Author

feihan commented Feb 23, 2021

@balachandr yes i would love to contribute.
Unfortunately i have very little knowledge about sqlcommenter yet.

@pankyriazo
Copy link

pankyriazo commented Mar 13, 2021

Hello, i would be happy to work on supporting TypeORM. Are there any additional guidelines besides the existing code?

@ninapavlich
Copy link

Hello! I would like to +1 this request!

@clintonb
Copy link

clintonb commented Jul 24, 2023

You can see the early history TypeORM comment support at typeorm/typeorm#3643. In order to support sqlcommenter—even manually adding comments—TypeORM will need to be updated to affix comments to the end of the query instead of prefixing to the beginning.

After further testing I have determined that prefixed comments show up in the Cloud SQL tool as well as Datadog. My sampling rate was too low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants