Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to "pause" the evaluation (aka breakpoint)? #408

Closed
AlmogBaku opened this issue Apr 16, 2022 · 5 comments
Closed

How to "pause" the evaluation (aka breakpoint)? #408

AlmogBaku opened this issue Apr 16, 2022 · 5 comments

Comments

@AlmogBaku
Copy link

Hi,
I'm wondering if/how it's possible to add some mechanism for breakpoints?

I saw that there are a few lines there is a "preparation" for hooking up a debugging breakpoint, but I couldn't find any way to hook there...

a. Is it possible today?
b. If that's not possible, I suggest adding a callback function in the thread or in a thread's local. If that is accepted, I'd be happy to do a PR. (The interface can be something simple like func(thread *Thread, typ BreakpointType)

@AlmogBaku
Copy link
Author

PS, might be related to #304

@AlmogBaku
Copy link
Author

@alandonovan WDYT? should I write a PR as described?

@pivotaljohn
Copy link

I think the now "proper" mention for Alan is: @adonovan.

@adonovan
Copy link
Collaborator

I saw that there are a few lines there is a "preparation" for hooking up a debugging breakpoint, but I couldn't find any way to hook there...

The 'vmdebug' logic is just an internal logging statement used when debugging changes to the interpreter. It's not a feature.

There is no breakpoint (debugger) feature today. The request to add this feature is #304, but there has been no progress towards that.

@AlmogBaku
Copy link
Author

AlmogBaku commented Apr 28, 2022

@adonovan are you against my proposed solution?
If that's acceptable, I'd be happy to write a PR

Edit: I meant to add this "hook" everywhere we have this vmdebug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants