Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle graph in & out a fixed number of layers #11

Closed
EatingW opened this issue Jul 6, 2020 · 0 comments · Fixed by #21
Closed

Toggle graph in & out a fixed number of layers #11

EatingW opened this issue Jul 6, 2020 · 0 comments · Fixed by #21
Assignees

Comments

@EatingW
Copy link
Collaborator

EatingW commented Jul 6, 2020

Poker planning notes:

  • Display a fixed depth or collapsing the node on click?
    • click is also used for metadata so using click might not be ideal
    • left click vs right click? cytoscape might not have a right click option
    • 2 buttons; up = reduce the layer, down = expand.
    • Decision: using drop down/user input for max depth from the root. Root = nodes with no in edges. Always show the roots.
  • What if the first layer (children of roots) is already 5000 nodes?
    • one use case: filter on one root and display the depth up to N for this root. (not in scope for this task)
  • Should the graph be mutated on the server side or client side?
    • Don't know how big the graph is, might be a lot of json data.
  • When are the roots determined?
  • roots stored in the server somewhere, created at initial graph creation, updated as mutations are applied
  • Steps:
    • client side add user input.
    • server side generate a graph that has only nodes up to a certain depth
    • give the graph as json to the client
  • How to consider this done?
    • server side unit tests for the roots.
    • server side unit tests for the max depth function for returning the graph
    • on the client side manually verify that the graph is only displayed up to a certain depth.
    • client side unit test that the client is sending the correct request to the server (request parameters)

Proposed estimate: 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants