You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Headers struct uses HashMap to hold key-value pairs. However, headers can have same keys. For conforming headers, we can join them into one string, but it is not the case for all headers, especially when their values can contain comma(s). Thus, sxg-rs should use a multi-map (e.g. HeaderMap in http).
I can help replacing the current implementation if you think it makes sense.
The text was updated successfully, but these errors were encountered:
Good catch. Note that the signed exchanges spec disallows duplicate headers, so the processor must join them with a comma before signing.
The HTTP spec considers this operation safe except for Set-Cookie but that's OK since the SXG spec disallows Set-Cookie anyway. (sxg-rs either strips it or cancels signing, depending on configuration.)
The Headers struct uses HashMap to hold key-value pairs. However, headers can have same keys. For conforming headers, we can join them into one string, but it is not the case for all headers, especially when their values can contain comma(s). Thus, sxg-rs should use a multi-map (e.g. HeaderMap in http).
I can help replacing the current implementation if you think it makes sense.
The text was updated successfully, but these errors were encountered: