Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wasm feature #343

Open
twifkak opened this issue Aug 18, 2022 · 0 comments
Open

Remove wasm feature #343

twifkak opened this issue Aug 18, 2022 · 0 comments

Comments

@twifkak
Copy link
Collaborator

twifkak commented Aug 18, 2022

In Rust, features are meant to be additive -- only introducing new APIs, not modifying or removing existing ones. Our wasm feature modifies existing APIs, leading to issues (e.g. bare cargo test fails because some packages require sxg_rs with wasm and others are incompatible with wasm).

Instead, I think we should make our wasm code conditional on target_family="wasm", and update our .github/workflow configs to build/test for both architectures, Linux and WASM (see rustc --print target-list for options and rustc -vV to print the default target).

I'm not sure how to disable certain packages on the wasm architecture, though, so maybe it doesn't solve the cargo test issue in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant