-static should not be used for build

[jirislaby]

The syz-repro tries to build with -static (csource/csource.go: Build), but this does not work on openSUSE, as we do not have static libraries. -static should be configurable at least.

[dvyukov]

It is configurable already. But maybe you won't like the default :)

NOSTATIC ?= 0
ifeq ($(NOSTATIC), 0)
        STATIC_FLAG=-static
endif

executor:
        $(CC) -o ./bin/syz-executor executor/executor.cc -pthread -Wall -O1 -g $(STATIC_FLAG) $(CFLAGS)

[dvyukov]

Ah, you mean csource/csource.go...

[dvyukov]

Will something like this work for you?

--- a/csource/csource.go
+++ b/csource/csource.go
@@ -199,7 +199,11 @@ func Build(src string) (string, error) {
                return "", fmt.Errorf("failed to create temp file: %v", err)
        }
        bin.Close()
-       out, err := exec.Command("gcc", "-x", "c++", "-std=gnu++11", src, "-o", bin.Name(), "-lpthread", "-static", "-O1", "-g").CombinedOutput()
+       out, err := exec.Command("gcc", "-x", "c++", "-std=gnu++11", src, "-o", bin.Name(), "-pthread", "-static", "-O1", "-g").CombinedOutput()
+       if err != nil {
+               // Some distributions don't have static libraries.
+               out, err = exec.Command("gcc", "-x", "c++", "-std=gnu++11", src, "-o", bin.Name(), "-pthread", "-O1", "-g").CombinedOutput()
+       }
        if err != nil {
                os.Remove(bin.Name())
                data, _ := ioutil.ReadFile(src)

[jirislaby]

Yes, indeed.