Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache and warmup #51

Closed
aomarks opened this issue Jun 7, 2019 · 0 comments · Fixed by #96
Closed

Cache and warmup #51

aomarks opened this issue Jun 7, 2019 · 0 comments · Fixed by #96
Assignees
Labels
Type: Enhancement New feature or request

Comments

@aomarks
Copy link
Member

aomarks commented Jun 7, 2019

Now that we do bare module rewriting, we're spending time parsing every HTML and JS request. This could distort first-contentful-paint measurements, and increases time waiting for benchmark results in all cases.

The best solution might be to add an in-memory cache to the Koa server for all requests, and to always do a single warmup run for each benchmark configuration before starting measurements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants