New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a different logging framework #139

Closed

tikue opened this issue Mar 30, 2017 · 1 comment

Assignees

Labels

Collaborator

tikue commented Mar 30, 2017

an interesting observation: we get ~10-20% higher throughput by removing all the debug logging calls in tarpc
things like trace! compiles to a memory load and a branch in the final code, which actually ends up mattering for common calls
I know slog (https://github.com/slog-rs/slog) has unused logging calls be completely compiled away
and also compose a bit more nicely

tikue added the performance label

tikue self-assigned this

Boscop mentioned this issue

env_logger performance, eliminating overhead of unused logging calls rust-lang/log#112

Closed

azban mentioned this issue

benchmark effect of logging near/nearcore#246

Closed

Collaborator Author

tikue commented Feb 4, 2024

I think this was obsoleted by using the tracing crate for logging.

tikue closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment