Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log spammed with OpenTelemetry subscriber not installed; making unsampled child context when used w/o Otel #373

Closed
Licenser opened this issue Aug 11, 2022 · 3 comments

Comments

@Licenser
Copy link

When using tarpc without otel it spams the logs with OpenTelemetry subscriber not installed; making unsampled child context on every request. This makes it quite unpleasant to use in this kind of scenario. It would get nice if the warning were limited to a single startup message instead of on every call or gated by a feature flag that selectively enables (or disables) OTel integration.

@tikue
Copy link
Collaborator

tikue commented Aug 11, 2022

Thanks for filing! I think the log level is too verbose right now. Would it be less intrusive if the log level were trace instead of warn?

@Licenser
Copy link
Author

Definitely, that would be totally fine for a solution! Thanks for the quick reply :) <3

@tikue
Copy link
Collaborator

tikue commented Aug 12, 2022

Fixed by 453ba1c

@tikue tikue closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants