Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Endianness #49

Closed
benlaurie opened this issue May 18, 2017 · 1 comment
Closed

Endianness #49

benlaurie opened this issue May 18, 2017 · 1 comment
Assignees
@przydatek

Comments

@benlaurie
Copy link

Surely this is a bad idea?

https://github.com/google/tink/blob/master/cc/core/crypto_format.cc#L47
@thaidn
Copy link
Contributor

thaidn commented May 19, 2017

This indeed looks like a bug, nice catch Ben!

Bartosz, FYI.

thaidn referenced this issue May 19, 2017
@przydatek @thaidn
Fixing endianness issue in C++ CryptoFormat.
801ae4e 
Change-Id: I34d1cbd202c6810c51269d712cb26b475a7f593a
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: 22cae5b2d8e156eae8efe5d65c4453dfec4e4edd
@thaidn thaidn closed this as completed May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@przydatek przydatek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thaidn @benlaurie @przydatek