Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wrap/unwrap? #5

Closed
shoyer opened this issue Dec 29, 2021 · 2 comments
Closed

Rename wrap/unwrap? #5

shoyer opened this issue Dec 29, 2021 · 2 comments

Comments

@shoyer
Copy link
Member

shoyer commented Dec 29, 2021

These are rather undescriptive names, and I guess most people (including myself!) will have to guess & check to keep them straight. :)

Some other possibilities, in rough order of increasing descriptiveness:

  • tree_wrap/tree_unwrap
  • transform/untransform
  • automath/undomath
  • vectorize/unvectorize
  • tree_vectorize/tree_unvectorize
  • vector_to_tree_func/tree_to_vector_func

Any favorites?

@soraros
Copy link

soraros commented Dec 29, 2021

The wrap/unwrap names alone are not very infomatie, but tree_math.wrap/unwrap are. Some of the names listed above even look redundant in the quantified form.

@shoyer
Copy link
Member Author

shoyer commented May 18, 2023

These names are probably good enough for now :)

@shoyer shoyer closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants