Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "prioritized" filter (like created, but for when issue was prioritized) #6

Closed
tstromberg opened this issue Apr 22, 2020 · 1 comment · Fixed by #72
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tstromberg
Copy link
Collaborator

This allows for us to accurately flag on older issues which were recently made a p0.

@tstromberg tstromberg added enhancement New feature or request help wanted Extra attention is needed labels Apr 22, 2020
@tstromberg
Copy link
Collaborator Author

The big question here is - how do we know how long an issue has been prioritized at a certain level?

Should we think in terms of how long an issue has been tagged a certain way rather than simulating priority?

If someone wants to take this on, here is what you'll need to edit, at a minimum:

Configuration

Add updated filter field:

Updated string `yaml:"updated,omitempty"`

Event fetching

We may need to add an API call to fetch issue labelling events. I'm not really sure. Maybe it's already covered by what we're already fetching.

// cachedIssues returns issues, cached if possible

State

Add updated state field:

Updated time.Time `json:"updated"`

Add state tracking here:

Filtering

Add filtering here:

if f.Responded != "" {

Testing

You may want to use cmd/tester for debugging. Example:

go run main.go --github-token-file ~/.github-personal-read --config ../../examples/skaffold.yaml --rule pr-reviewable --alsologtostderr -v=3 --num 4028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant