Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark assertThat(Collection<T>) @Deprecated #168

Closed
PhilippWendler opened this issue Dec 19, 2014 · 3 comments
Closed

Do not mark assertThat(Collection<T>) @Deprecated #168

PhilippWendler opened this issue Dec 19, 2014 · 3 comments
Assignees
Labels
type=documentation Documentation that is other than for an API

Comments

@PhilippWendler
Copy link

After upgrading to Truth 0.25, all my tests about collections and sets produce deprecation warnings because Truth.assertThat(Collection<T>) is now annotated with @Deprecated.

I now have to either use @SuppressWarnings or add an ugly explicit upcast to Iterable for each of these tests. Please consider removing either the annotation or the whole method.

@JakeWharton
Copy link

Agree. This has bit me all over and I've just chosen to ignore it under the assumption that it would be removed soon.

@kluever
Copy link
Member

kluever commented Dec 19, 2014

Ahh, good point...hmm, we do intend to remove the assertThat(Collection) overload very soon.

But I guess there's no harm in leaving the assertThat(Collection) method undeprecated, given that all the methods you can chain after that on CollectionSubject are deprecated as well.

@kluever kluever self-assigned this Dec 19, 2014
@kluever kluever added the type=documentation Documentation that is other than for an API label Dec 19, 2014
@kluever
Copy link
Member

kluever commented Dec 19, 2014

OK, I've undeprecated these internally...not sure if we plan to roll an entire new release just to get these out there, but it'll be mirroed out to github soon-ish.

@kluever kluever closed this as completed Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type=documentation Documentation that is other than for an API
Projects
None yet
Development

No branches or pull requests

3 participants