ASSERT.that(map) API

[yujige]

Some potential assertions:

void isEmpty();

IntegerSubject size();

CollectionSubject keys();

CollectionSubject values();

MapSubject contains(key, value);

That way, I can do:

ASSERT.that(map).size().isEqualTo(10);
ASSERT.that(map).keys().hasAnyOrder(a, b);
ASSERT.that(map)
.contains(key1, value1)
.contains(key2, value2)

[cgruber]

So, some things aren't worth the API weight, I think. And in this case, I think a few of them are easier to just write:

ASSERT.that(map.size()).is(10);
ASSERT.that(map.keys()).has().allOf(a, b);

but some valid assertions directly on the map seem to be:

ASSERT.that(map).hasKey("foo").withValue("bar");

This is similar to the hasField("foo").withValue("bar"); pattern used in Subject itself, and it makes sense here.

AS to the others, it's sort of cute, but I'm just not sure it's worth it. Now the same thing can be said about all subject methods, and you can represent any of these propositions with assertTrue(somePredicate) in theory, so maybe I'm being too conservative here. I just feel like it doesn't add anything, where hasKey().withValue() seems to.

Thoughts? I'll certainly start there.

[cgruber]

Initial MapSubject created and merged. Closing this. Feel free to open it or another if more features are desired on MapSubject than

hasKey()
hasKey().withValue()
lacksKey()
lacksValue()
isEmpty()
isNotEmpty()